Conversation
|
hey @rutb327 could you open this PR against the apache/iceberg-python repo? |
kevinjqliu
reviewed
Aug 11, 2025
| assert spec.fields[i] == expected_partition_fields[i] | ||
|
|
||
|
|
||
| @pytest.mark.integration |
There was a problem hiding this comment.
thanks for this test! could you add another one to check that the same check is applied with creating the table with both schema and partition spec?
something like
schema = Schema(
NestedField(1, "id", LongType(), required=False),
NestedField(2, "event_ts", TimestampType(), required=False),
NestedField(3, "another_ts", TimestampType(), required=False),
NestedField(4, "str", StringType(), required=False),
)
partition_spec = PartitionSpec(
PartitionField(source_id=1, field_id=1000, transform=IdentityTransform(), name="id"), spec_id=1
)
table = _create_table_with_schema(catalog, schema, "2", partition_spec)
There was a problem hiding this comment.
and perhaps add a test for when the partition field is already there and we try to add a new schema field which will conflict
Owner
Author
There was a problem hiding this comment.
I have raised the PR against the apache/iceberg-python. I will add these tests
Co-authored-by: Fokko Driesprong <fokko@apache.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes 2272
Rationale for this change
Implements the validation logic described in 2272to match Java and Rust behavior for partition field name conflicts with schema fields.
This mirrors the method in Java checkAndAddPartitionName():
https://github.com/apache/iceberg/blob/4dbc7f578eee7ceb9def35ebfa1a4cc236fb598f/api/src/main/java/org/apache/iceberg/PartitionSpec.java#L392-L416
Identity transforms (
sourceColumnID != null)- Allow schema field name conflicts only when sourced form the same fieldNon-identity (
sourceColumnID == null)- Disallow any schema field name conflicts.In this PR
isinstance(transform, (IdentityTransform, VoidTransform))is used to achieve the same logic as Java’ssourceColumnIDcheck.Are these changes tested?
Yes, all existing tests pass and added a test covering validation scenarios.
Are there any user-facing changes?
Yes. Non-identity transforms can no longer use schema field names as partition field names.